Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove auto_number test #101

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Remove auto_number test #101

merged 1 commit into from
Dec 8, 2023

Conversation

comnik
Copy link
Contributor

@comnik comnik commented Dec 7, 2023

In next week's release we are dropping support for auto_number as part of the surface area reduction initiative. This PR removes a test case that would likely break the SDK tests then.

@comnik comnik requested review from wienleung and azreika December 7, 2023 10:35
@comnik comnik self-assigned this Dec 7, 2023
Copy link
Contributor

@azreika azreika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yayyy bye!!!!!!! Thank you!

In the past there were other places that AutoNumber comes about -- might be worth cross-checking with https://github.com/RelationalAI/rai-sdk-go/pull/82/files that all of those are gone

@comnik
Copy link
Contributor Author

comnik commented Dec 8, 2023

Thanks @azreika . This was the only test usage. I'll file an issue to drop AutoNumber support entirely here.

@comnik comnik merged commit 74ddab6 into main Dec 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants